Skip to content

[GSK-541] Migrate Vue components to Composition API #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 7, 2023
Merged

[GSK-541] Migrate Vue components to Composition API #1232

merged 16 commits into from
Jul 7, 2023

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Jul 4, 2023

Description

This PR migrates the following components to Composition API:

  • AuthPortal.vue
  • CustomInspectionFilter.vue
  • EditableLabel.vue
  • ErrorToast.vue
  • FeedbackPopover.vue
  • InspectionFilter.vue
  • ModelSelector.vue
  • MultiSelector.vue
  • RouterComponent.vue
  • UploadButton.vue

Related Issue

GSK-541 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
@linear
Copy link

linear bot commented Jul 4, 2023

GSK-541 Migrate vue component declaration from @Component to composition API

GSK-351

Newly created components should ONLY use composition API of Vue 2.7

Migration:

vue-property-decorator library doesn't support Vue 3, so in order to migrate to Vue 3 we have to migrate component definition from Component to composition API

  • Admin.vue
  • AdminUsers.vue
  • App.vue
  • AuthPortal.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • ButtonModalConfirmation.vue
  • CreateUser.vue
  • CustomInspectionFilter.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • Dashboard.vue
  • DatasetSelector.vue
  • Datasets.vue
  • EditUser.vue
  • EditableLabel.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • Dashboard.vue
  • ErrorToast.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • FeedbackDetail.vue
  • FeedbackList.vue
  • FeedbackPopover.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • InspectionFilter.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • Inspector.vue [DONE: feature/gsk-1289-ui-issue-incorrect-colour-of-correctly-predicted-labels]
  • InspectorLauncher.vue
  • InspectorWrapper.vue
  • InviteUsers.vue
  • Login.vue
  • Main.vue
  • MessageReply.vue
  • ModelSelector.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • Models.vue
  • MultiSelector.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • OverlayLoader.vue
  • PasswordRecovery.vue
  • PredictionExplanations.vue
  • PredictionResults.vue [DONE: feature/gsk-1289-ui-issue-incorrect-colour-of-correctly-predicted-labels]
  • Project.vue
  • ProjectsHome.vue
  • ResetPassword.vue
  • ResultPopover.vue [DONE: feature/gsk-1289-ui-issue-incorrect-colour-of-correctly-predicted-labels]
  • RouterComponent.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • Signup.vue
  • Start.vue
  • TestSuite.vue
  • TestSuites.vue
  • TextExplanation.vue
  • UploadButton.vue [DONE: feature/gsk-541-migrate-vue-component-declaration-from-component-to]
  • UserProfile.vue
  • UserProfileEditPassword.vue

Project: Giskard
Reporter: aavtomonov
Created: 2022-11-13
@henchaves henchaves requested a review from kevinmessiaen July 4, 2023 14:15
@henchaves henchaves self-assigned this Jul 4, 2023
kevinmessiaen
kevinmessiaen approved these changes Jul 7, 2023
View reviewed changes
henchaves and others added 5 commits July 7, 2023 10:47
@henchaves @kevinmessiaen
Update frontend/src/components/UploadButton.vue
c6e9a10 
Co-authored-by: Kevin Messiaen <114553769+kevinmessiaen@users.noreply.github.com>
@henchaves
Merge branch 'main' into feature/gsk-541-migrate-vue-component-declar…
13643fa 
…ation-from
@henchaves
Remove unused import
8f58b49
@henchaves
Merge branch 'feature/gsk-541-migrate-vue-component-declaration-from'…
eed2bac 
… of github.com:Giskard-AI/giskard into feature/gsk-541-migrate-vue-component-declaration-from
@henchaves
Merge branch 'main' into feature/gsk-541-migrate-vue-component-declar…
c938e7c 
…ation-from
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication
@henchaves henchaves merged commit 1b68849 into main Jul 7, 2023
@Hartorn Hartorn deleted the feature/gsk-541-migrate-vue-component-declaration-from branch September 13, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@henchaves @kevinmessiaen