[GSK-1300] Reorganize breadcrumbs #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSK-1300 Reorganize breadcrumbs
On every page move the actual page title below the breadcrumbs and make it larger |
henchaves
requested review from
Googleton,
andreybavt and
kevinmessiaen
and removed request for
andreybavt and
kevinmessiaen
kevinmessiaen
requested changes
Jun 27, 2023
Member
kevinmessiaen
left a comment
kevinmessiaen
left a comment
There was a problem hiding this comment.
I'm not a big fan that we put some part of the breadcrumb in the project home and then continue it inside of each component with a hack to but it in the right location.
For me better solution would be to have:
- A Breadcrumb component that is called directly in each component
- A dynamic component in ProjectHome based on some route props giving the correct route name
kevinmessiaen
approved these changes
Jul 7, 2023
| margin: 0 auto; | ||
| } | ||
| ::v-deep .v-toolbar__content { |
Member
There was a problem hiding this comment.
Do we still need this style?
| cursor: default; | ||
| } | ||
| ::v-deep .v-toolbar__content { |
Member
There was a problem hiding this comment.
Same here do we need to keep this style?
| margin-top: 10px !important; | ||
| } | ||
| ::v-deep .v-toolbar__content { |
Member
There was a problem hiding this comment.
Do we need to keep this style?
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to change how breadcrumbs are displayed.
The idea is to move the title of the current tab to below the breadcrumbs, making it more visible to the user.
Related Issue
GSK-1300 (available on Linear)
Type of Change