Skip to content

Conversation

@henchaves
Copy link
Member

Description

This PR aims to make easier for the user to copy the project key of a given project.
Now, the user can copy a key from the list of projects and also can see the key on the breadcrumbs.

Related Issue

GSK-1297 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
@linear
Copy link

linear bot commented Jun 14, 2023

GSK-1297 Add project key copy button

image.png

Also add project key to the breadcrumbs:

image.png

@henchaves henchaves requested a review from kevinmessiaen June 14, 2023 13:52
<span>/</span>
<router-link :to="{ name: 'project-properties', params: { id } }">
{{ project.name }}
{{ project.name }} ({{ project.key }})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a - to make it more readable

Suggested change
{{ project.name }} ({{ project.key }})
{{ project.name }} - ({{ project.key }})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but do we keep using the round brackets around project.key ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@henchaves henchaves merged commit 05c7977 into main Jun 15, 2023
@Hartorn Hartorn deleted the feature/gsk-1297-add-project-key-copy-button branch September 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants