-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
Composio tool auth fixes, no auth support and connected accounts selection. #5614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @chiragjagga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Composio tool's integration capabilities by introducing support for applications that do not require authentication and allowing users to explicitly choose from multiple connected accounts for a given application. These changes enhance the tool's adaptability and user control, addressing a known issue and providing a more robust interaction model. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several improvements to the Composio tool integration, including support for applications without authentication and allowing users to select from multiple connected accounts. The changes are well-implemented and address the described goals.
My review includes a few suggestions to enhance the code quality:
- Improving type safety by replacing
anywith specific interfaces for Composio API objects. - Refactoring duplicated logic into a helper function for better maintainability.
- Adding a necessary check to prevent potential runtime errors when an application is not selected.
Overall, this is a great update that significantly improves the usability of the Composio tool.
…ga/Flowise into composio-legacypkg-fix
Note:
No Auth:

No Connections Available:

Valid active connections:

Workflow:
Composio_fix.2.1.mp4