-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
feat: allow loading nodes from env-specified paths #4949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Fantastic pr |
|
Best PR I have seen from the open-source community for this project so far. Love it. |
|
awesome addition! curious how this work? you need to build the component files as well right? in the |
That is the idea, yes. I haven't set up anything to facilitate that in this PR, as I figured it would need more discussion; this just sets it up to work if you can get the components built. But I did do a simple textsplitter component locally to test; can share that if it would be helpful. Just cloned the relevant bits of the interfaces etc for now. |
|
@jmorahan I’ve been testing this out and wanted to highlight 2 points:
And here is the thing, if I’m understanding correctly, when we want to make a simple change to a node like the Loop node, we need to change its default It would be very helpful if external nodes with the same system names could override the native node by default. |
|
Following my above comment, I have added the ability to override existing nodes, as the more optimal way to work with this new feature. Now, we can create nodes and components from scratch using unique Changes: bd17c55 |



This allows you to specify additional paths in an environment variable so you can maintain custom components outside of the core codebase