Skip to content

Conversation

@DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Nov 20, 2025

This removes the Q_DECLARE_TYPEINFO Macro from the VAbstractCurve class for Qt ver 6.7.0 or later that prevents the apps from building.

Closes issue #1427

@DSCaskey DSCaskey requested a review from csett86 November 20, 2025 11:55
@DSCaskey DSCaskey self-assigned this Nov 20, 2025
@what-the-diff
Copy link

what-the-diff bot commented Nov 20, 2025

PR Summary 🌟

  • Revamped Documentation 📝
    The makeover of header documentation in vabstractcurve.h has helped tremendously in enhancing its clarity and establishing consistency! It's now so much more readable and easy to follow. 😃

  • Updated Copyright Year 📅
    The epoch year for Seamly, LLC's copyright has been updated from 2023 to 2025! This small, yet important detail aligns perfectly with the current business operation. 💼✅

  • Polished Comment Layout 🧹
    The unnecessary comment sections were caught and promptly removed, replacing them with a cleaner and more elegant format. Talk about the beautification of our code! 🎉🎊

  • Improved Compatibility Checks 💻
    Although the existing inclusion guard was maintained, compatibility checks for QT version were added. Hooray for a smoother and more robust software experience! Kudos to this meticulous work! 💪🎖️

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the definition of a movable type from https://doc.qt.io/qt-6/qtypeinfo.html I think that VAbstractCurve was never movable. So lets just remove that type decl for all qt versions, then its treated as the default Q_COMPLEX_TYPE

@DSCaskey agree?

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Nov 21, 2025

So lets just remove that type decl for all qt versions,

@csett86 Agreed.

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DSCaskey

@csett86 csett86 merged commit 94c2a38 into develop Nov 21, 2025
12 checks passed
@csett86 csett86 deleted the fix-VAbstractCurve-build-error branch November 21, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants