Skip to content

Update how global variables are matched #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brianherold wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update how global variables are matched #21

brianherold wants to merge 5 commits into from

Conversation

@brianherold
Copy link

@brianherold brianherold commented Sep 1, 2022

I was surprised how many global variables this found in the codebase I'm working in, so I looked into it. Turns out some of the globals it found weren't actually globals, and it missed some actual globals.

I added test cases for the 4 types of missing or false globals I found, then updated the code to pass the tests.
@brianherold
Update how global variables are matched
b73f8b8 
Updated how code was removed from within brackets. Previous method did not work well with nested brackets.

Added match for global pointers

Added match for global sized array where size is from #define

Updated how line number match worked for special cases
@brianherold
Clarity update
d20a988
@brianherold
Rename function
823fc6c
@brianherold
Strip mid-line comments
e66d7ae
@brianherold
Remove a few other false matches of globals
d906b24
@brianherold
Copy link
Author

brianherold commented Sep 6, 2022

I found a few other false global variables, so I pushed some additional code changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@brianherold