set default value for '_onDisconnectfn'#221
Merged
mathieucarbou merged 2 commits intoESP32Async:mainfrom Jul 8, 2025
Merged
Conversation
mathieucarbou
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR initializes the newly added _onDisconnectfn member to NULL in the AsyncWebServerRequest constructor, preventing undefined behavior when the pointer is later checked.
- Added
_onDisconnectfn(NULL)to the initializer list.
Comments suppressed due to low confidence (2)
src/WebRequest.cpp:25
- [nitpick] Consider using nullptr instead of NULL for pointer initialization in C++ to improve type safety and clarity.
: _client(c), _server(s), _handler(NULL), _response(NULL), _onDisconnectfn(NULL), _temp(), _parseState(PARSE_REQ_START), _version(0), _method(HTTP_ANY),
src/WebRequest.cpp:25
- [nitpick] Ensure the initializer list order matches the declaration order of class members to avoid compiler warnings and improve maintainability.
: _client(c), _server(s), _handler(NULL), _response(NULL), _onDisconnectfn(NULL), _temp(), _parseState(PARSE_REQ_START), _version(0), _method(HTTP_ANY),
me-no-dev
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value is checked here to be different from zero:
ESPAsyncWebServer/src/WebRequest.cpp
Lines 266 to 268 in 2803989
To have a defined behavior I would recommend to set
_onDisconnectfntoNULL