Skip to content

CLI: only push a dioxus/* fallback feature if the crate being compiled depends on the dioxus crate. #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkelleyrtp merged 1 commit into from
Dec 28, 2025
Merged

CLI: only push a dioxus/* fallback feature if the crate being compiled depends on the dioxus crate. #5143

jkelleyrtp merged 1 commit into from
Dec 28, 2025

Conversation

@nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Dec 27, 2025 •
edited
Loading

This allows the CLI to compile crates which do not depend on the dioxus crate for Android and iOS targets (for example crates which depend on dioxus_native directly).

Without this patch, the CLI unconditionally injects the dioxus/mobile feature when passing --android or --ios which causes the build to fail if the dioxus crate is not a depdendency.
@nicoburns nicoburns added the cli Related to the dioxus-cli program label Dec 27, 2025
@nicoburns nicoburns requested a review from a team as a code owner December 27, 2025 01:28
@nicoburns nicoburns mentioned this pull request Dec 28, 2025
Merged
@jkelleyrtp jkelleyrtp merged commit c68a47b into DioxusLabs:main Dec 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the dioxus-cli program

2 participants

@nicoburns @jkelleyrtp