Prevent hot patch from leaving devserver in BuildError state #4784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scenario: without this patch, if you fail a build, fix the code, let the thin build succeed, and then refresh the browser... then after reloading the browser page, it gets stuck on the "One sec" loader because the devserver status never clears the earlier BuildError. - mark build status ready after sending hot patch messages so refreshes succeed - reuse the same helper from reload command to avoid stale loading screens - add set_ready() helper to avoid duplicate status broadcasts
tekacs
force-pushed
the
mark-build-ready
branch
from
e00a9b6 to
bb3d6ec
Compare
ealmloff
added
cli
jkelleyrtp
approved these changes
Oct 14, 2025
Member
|
Thank you for helping with the bugs!! |
Contributor
Author
|
@jkelleyrtp Thank you for subsecond! I've been waiting so long to switch out frontend to Rust, had no idea when someone would finally get to building something like subsecond and it's a joy, even if there's teething to work through. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario: without this patch, if you fail a build, fix the code, let the thin build succeed, and then refresh the browser... then after reloading the browser page, it gets stuck on the "One sec" loader because the devserver status never clears the earlier BuildError. Prior to this patch, only a full rebuild fixes it.
This PR is tested, working correctly in other exercises including error, and found to fix the issue.