Skip to content

Fix url encoding query and implement FromQueryArgument for Option<T> #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ealmloff merged 7 commits into from
Jun 2, 2025
Merged

Fix url encoding query and implement FromQueryArgument for Option<T> #4213

ealmloff merged 7 commits into from
Jun 2, 2025

Conversation

@ealmloff
Copy link
Member

@ealmloff ealmloff commented May 27, 2025 •
edited
Loading

Different parts of the URL have different characters that need to be escaped. This PR switches to percent-encoding across the workspace and creates percent encoding sets for each part of the url

Fixes #2984
Fixes #2781
@ealmloff ealmloff requested a review from a team as a code owner May 27, 2025 19:53
@ealmloff ealmloff added bug Something isn't working router Related to the router implementation labels May 27, 2025
@ealmloff ealmloff changed the title Fix url encoding query May 27, 2025
@ealmloff ealmloff added enhancement New feature or request breaking This is a breaking change labels May 27, 2025
@ealmloff ealmloff merged commit 9b16cbf into DioxusLabs:main Jun 2, 2025
18 of 19 checks passed
AnteDeliria pushed a commit to AnteDeliria/dioxus that referenced this pull request Jun 2, 2025
@ealmloff @AnteDeliria
Fix url encoding query and implement FromQueryArgument for Option<T> (D…
efd384e 
…ioxusLabs#4213)

* Fix url encoding queries

* handle percent encoding hash fragments

* implement fromqueryargument for Option<T>

* fix tests

* fix typo
AnteDeliria pushed a commit to AnteDeliria/dioxus that referenced this pull request Jul 23, 2025
@ealmloff @AnteDeliria
Fix url encoding query and implement FromQueryArgument for Option<T> (D…
44cdd9c 
…ioxusLabs#4213)

* Fix url encoding queries

* handle percent encoding hash fragments

* implement fromqueryargument for Option<T>

* fix tests

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This is a breaking change bug Something isn't working enhancement New feature or request router Related to the router implementation

2 participants

@ealmloff @jkelleyrtp