Skip to content

Fix form value collecting from form element instead of input element #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkelleyrtp merged 1 commit into from
Mar 28, 2022
Merged

Fix form value collecting from form element instead of input element #333

jkelleyrtp merged 1 commit into from
Mar 28, 2022

Conversation

@naturalethic
Copy link

@naturalethic naturalethic commented Mar 27, 2022

No description provided.

@naturalethic
Copy link
Author

naturalethic commented Mar 27, 2022

That title isn't perhaps clear. I noticed that for TextAreas, I was getting a value of all the text within the form itself. In the three non-input type value matchers below the main one, I noticed that it was matching against the form element itself. So the first two would fail to match, and it would default to taking all the text in the third one from the form element.
@jkelleyrtp
Copy link
Member

jkelleyrtp commented Mar 28, 2022

Ah yep - this matches the desktop bindings. Thank you for finding this!
@jkelleyrtp jkelleyrtp merged commit 6c72ed5 into DioxusLabs:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@naturalethic @jkelleyrtp