Skip to content

Fix deref for mapped Write structs in dioxus-signals #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ealmloff merged 1 commit into from
Oct 16, 2023
Merged

Fix deref for mapped Write structs in dioxus-signals #1549

ealmloff merged 1 commit into from
Oct 16, 2023

Conversation

@esimkowitz
Copy link
Contributor

@esimkowitz esimkowitz commented Oct 16, 2023 •
edited
Loading

When mapping a Write struct in dioxus-signals, the new Write that is created cannot be dereferenced. This is because the default constraint for the Write struct ties the inner type to the type for the signal. When mapping the inner type to a new type, this constraint is broken. Explicitly separating the type constraints for the inner and the signal allows for dereferencing of the new mapped Write.
@esimkowitz esimkowitz mentioned this pull request Oct 16, 2023
Merged
jkelleyrtp
jkelleyrtp approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jkelleyrtp jkelleyrtp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@esimkowitz esimkowitz changed the title Fix deref for Write struct in dioxus-signals Oct 16, 2023
@ealmloff ealmloff merged commit b1d6069 into DioxusLabs:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@esimkowitz @jkelleyrtp @ealmloff