Use a gen in PartialEq for UseSharedState
#1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
requested changes
Aug 22, 2023
ealmloff
added
enhancement
DanielAlbl
force-pushed
the
gen-in-use-shared-state
branch
from
74f7f01 to
818edaf
Compare
DanielAlbl
force-pushed
the
gen-in-use-shared-state
branch
from
818edaf to
46cf79b
Compare
ealmloff
approved these changes
Sep 2, 2023
Member
ealmloff
left a comment
ealmloff
left a comment
There was a problem hiding this comment.
Sorry I lost track of this. Looks good, thank you!
Member
|
Clippy failure is unrelated. This change can potentially be breaking (this could fail to memorize some props). Waiting for a second review before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I had tried using a
UseSharedStateas a dependency foruse_future, and it wasn't re-running when it changed. I think this was because it was comparing the.innervalues which still were pointing to the same data.I implemented a special
UseFutureDepso it would compare agenvalue, sort of following the example ofUseRef. I did have to remove thePartialEqhere to avoid conflicting with this:impl<A: Dep> UseFutureDep for &A, but this might not be the right thing to do.