Skip to content

deps: Update keyboard-types to 0.7. #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ealmloff merged 1 commit into from
Aug 21, 2023
Merged

deps: Update keyboard-types to 0.7. #1378

ealmloff merged 1 commit into from
Aug 21, 2023

Conversation

@waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Aug 20, 2023

This brings a use of bitflags 2 and a couple of minor features.
@waywardmonkeys
Copy link
Contributor Author

waywardmonkeys commented Aug 21, 2023

This will require blitz to be updated as well since the dependency is used in the interface of dioxus-html. (Perhaps a re-export of keyboard-types from somewhere and using it via the re-export from blitz-core would be better...)
ealmloff
ealmloff approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Re-exporting keyboard types in blitz core would be better
@ealmloff ealmloff merged commit d8704a0 into DioxusLabs:master Aug 21, 2023
@waywardmonkeys waywardmonkeys deleted the update-keyboard-types branch August 21, 2023 14:35
@waywardmonkeys
Copy link
Contributor Author

waywardmonkeys commented Aug 21, 2023

The original usage is from here in crates in this repo, so the pub use should be here, so that blitz-core can just pick it up when it picks up the structs that it is importing ... I'll take a look in the next day or three.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@waywardmonkeys @ealmloff