CLI: Behavior when web.https.mkcert is not specified. #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user, I expect that if
web.https.enabled = trueandweb.https.mkcert = falseor unspecified,web.https.cert_pathandweb.https.key_pathmust be present.This is just a usability improvement since I stumbled on this. At first, I thought HTTPS support was only partially implemented since I couldn't find docs for it. But then I decided to read the code and I noticed that
web.https.mkcert = falsemust be explicitly set otherwise the certificate and key in the configuration file would be ignored.This PR simply breaks down the function into two: one to handle certificates when
mkcert = true; the other to handle certificates whenmkcert = falseor unspecified.