Skip to content

FileEngine: expose native file types on different platforms #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ealmloff merged 2 commits into from
Aug 17, 2023
Merged

FileEngine: expose native file types on different platforms #1258

ealmloff merged 2 commits into from
Aug 17, 2023

Conversation

@wooden-worm
Copy link
Contributor

@wooden-worm wooden-worm commented Jul 27, 2023

Impl get_native_file to return the native file type on different platforms: web_sys::File on wasm and tokio::fs::File on desktop.

Fixes #1081
@ealmloff ealmloff added enhancement New feature or request html Related to the html crate labels Jul 31, 2023
ealmloff
ealmloff approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great!
@ealmloff ealmloff merged commit f652474 into DioxusLabs:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request html Related to the html crate

2 participants

@wooden-worm @ealmloff