Skip to content

Fix rejected request when receiving HTTP header "Expect: 100-continue" #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gittiver merged 1 commit into from
Jan 9, 2024
Merged

Fix rejected request when receiving HTTP header "Expect: 100-continue" #727

gittiver merged 1 commit into from
Jan 9, 2024

Conversation

@bruvey37
Copy link
Contributor

@bruvey37 bruvey37 commented Dec 6, 2023

The purpose of this pull request is to fix #626 without impacting CVE-2022-38667 correction.

Request parser information will no be cleared in case of requested header is "Expect: 100-continue"
@jpblemes jpblemes mentioned this pull request Dec 19, 2023
Closed
@gittiver gittiver linked an issue Jan 3, 2024 that may be closed by this pull request
Unable to send POST request to Crow Server for request bodies larger than 1024 Bytes #731
Closed
@bruvey37
Copy link
Contributor Author

bruvey37 commented Jan 3, 2024 •
edited
Loading

Hi @gittiver,
Is it possible to restart the unit test workflow?
I've just run the unit tests on my side (https://github.com/bruvey37/Crow/actions/runs/7399645970) and all went well.
I don't see how my modification could have had an impact on multi-server operation only on macOS 12 (unit tests went further on macOS 11)... It seems something wrong happens during workflow execution...?

Thanks :)
@gittiver
Copy link
Member

gittiver commented Jan 4, 2024

Hi @gittiver, Is it possible to restart the unit test workflow? I've just run the unit tests on my side
done.
@gittiver gittiver merged commit 78d1d2b into CrowCpp:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@bruvey37 @gittiver