Skip to content

Fix windows build and remove deprecated macOS10.15 builder in github action for build and test #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
The-EDev merged 2 commits into from
Jun 4, 2023
Merged

Fix windows build and remove deprecated macOS10.15 builder in github action for build and test #648

The-EDev merged 2 commits into from
Jun 4, 2023

Conversation

@gittiver
Copy link
Member

@gittiver gittiver commented May 30, 2023 •
edited
Loading

add windows to built platforms and fixed the GitHub build for it. includes also removing deprecated macOS10.15 builder from GitHub-action.
@gittiver gittiver marked this pull request as draft May 30, 2023 10:01
@gittiver gittiver force-pushed the fix_windows_build branch 4 times, most recently from fc89866 to c036e5b Compare May 30, 2023 14:58
@gittiver gittiver marked this pull request as ready for review May 30, 2023 15:01
@gittiver gittiver changed the title Fix windows build May 30, 2023
@The-EDev
Copy link
Member

The-EDev commented May 30, 2023

I have a feeling the free points we have are gonna run out very quickly...
@gittiver
Copy link
Member Author

gittiver commented May 30, 2023 •
edited
Loading

I have a feeling the free points we have are gonna run out very quickly...

We had some actions which runs more than a day:
https://github.com/CrowCpp/Crow/actions/runs/5049154209

24*60 = 1440 min
And there are only 2000 min per month. We should analyze this and maybe set limits when to cancel.

We could half the time if we just build macOS-latest, ubuntu-latest, windows-latest. For PRs this could be sufficient.
@The-EDev
Copy link
Member

The-EDev commented May 30, 2023 •
edited
Loading

well this is weird, the usage for this check was 53 minutes but the billing section shows 0 minutes used, any idea what's up with that?
@gittiver gittiver force-pushed the fix_windows_build branch from c036e5b to 9a0ac34 Compare May 30, 2023 21:08
@gittiver
Copy link
Member Author

gittiver commented May 30, 2023

well this is weird, the usage for this check was 53 minutes but the billing section shows 0 minutes used, any idea what's up with that?

no.
@gittiver
Copy link
Member Author

gittiver commented May 30, 2023 •
edited
Loading

Windows build works now,finally removed windows 2019 build to spare minutes and cleaned up and sqashed commits.

From my side, PR is ready for review and if no findings on it, also for merge.

It could be a follow up to optimize the time further, didn't try jobcontrol on cmake-build, also for PRs we could limit the platform builds to less platforms. In terms of minutes, windows build is the most expensive.
The-EDev
The-EDev reviewed May 31, 2023
View reviewed changes
@The-EDev
Copy link
Member

The-EDev commented May 31, 2023 •
edited
Loading

I wonder if there's a way to disable windows and macos tests until ubuntu ones succeed...
@The-EDev The-EDev mentioned this pull request May 31, 2023
Closed
@gittiver
Copy link
Member Author

gittiver commented Jun 1, 2023 •
edited
Loading

I wonder if there's a way to disable windows and macos tests until ubuntu ones succeed...

yes change fail-fast to true. :) for testing the other way was better.

strategy:
fail-fast: false

Its fixed now.
@gittiver gittiver force-pushed the fix_windows_build branch from 9a0ac34 to db008d7 Compare June 1, 2023 11:14
@gittiver gittiver requested a review from The-EDev June 1, 2023 11:18
@gittiver gittiver mentioned this pull request Jun 1, 2023
Closed
@The-EDev The-EDev linked an issue Jun 1, 2023 that may be closed by this pull request
GitHub build does not contain windows build and test #635
Closed
@gittiver gittiver force-pushed the fix_windows_build branch from db008d7 to 727e6fc Compare June 2, 2023 07:29
@The-EDev The-EDev merged commit 9f548a9 into CrowCpp:master Jun 4, 2023
@gittiver gittiver deleted the fix_windows_build branch June 8, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@gittiver @The-EDev