Skip to content

use GNUInstallDirs for CMake installation #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
The-EDev merged 1 commit into from
Jun 8, 2023
Merged

use GNUInstallDirs for CMake installation #642

The-EDev merged 1 commit into from
Jun 8, 2023

Conversation

@topazus
Copy link
Contributor

@topazus topazus commented May 23, 2023

Use GNUInstallDirs module which provides reasonable variables of path can facilitate the CMake installation.
eg. lib replaced by CMAKE_INSTALL_LIBDIR and include replaced by CMAKE_INSTALL_INCLUDEDIR.

Ref: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
@The-EDev
Copy link
Member

The-EDev commented Jun 8, 2023

Will this work on windows as well?
@topazus
Copy link
Contributor Author

topazus commented Jun 8, 2023

@The-EDev I did not test it on Windows. I just did some packaging in Fedora, and GNUInstallDirs conforms to the current cmake pratice in Linux. But there are other CMake-used libraries, which they take the GNUInstallDirs for the cmake installation, and someone said it worked on Windows/Linux/MacOS, like SFML/SFML#1563 (comment)
@The-EDev The-EDev merged commit fc14a32 into CrowCpp:master Jun 8, 2023
KaSSaaaa added a commit to KaSSaaaa/Crow that referenced this pull request Aug 8, 2023
@KaSSaaaa
CrowCpp#642 CR : use const& instead of && for subprotocols parameter
5342dd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@topazus @The-EDev