Skip to content

Cpp17 filesystem usage fixes #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
The-EDev merged 2 commits into from
Aug 7, 2022
Merged

Cpp17 filesystem usage fixes #514

The-EDev merged 2 commits into from
Aug 7, 2022

Conversation

@erikaldsund
Copy link
Contributor

@erikaldsund erikaldsund commented Aug 5, 2022

Two fixes:

  • std::filesystem::path cannot be implicitly converted to std::string (2d04bd4)
  • Using std::filesystem in C++17 mode on gcc versions prior to gcc 8 is cumbersome (9c496bc). Proposition avoids using it for the reasons mentioned in the commit message.
@erikaldsund @The-EDev
Fix compilation error using std::filesystem::path
99c4569 
A std::filesystem::path is not implicitly convertible to a std::string.
@erikaldsund @The-EDev
Don't use std::filesystem when compiling in C++17 mode on gcc < 8
b127671 
On gcc < 8, filesystem had to be included as <experimental/filesystem>, it
was also living in the std::experimental namespace, and also required the user
to link against -lstdc++fs.
@The-EDev The-EDev force-pushed the cpp17_filesystem_usage_fixes branch from 9c496bc to b127671 Compare August 5, 2022 21:59
dranikpg
dranikpg approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@dranikpg dranikpg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

A __has_include() would be probably more reliable, than a version check.

Like you mentioned, g++ 5 till 7 have experimental support. Including is no problem, but not forgetting to link requires some cmake changes, so I'd also just leave it as it was 😄
@The-EDev The-EDev merged commit 87cf68f into CrowCpp:master Aug 7, 2022
@The-EDev The-EDev mentioned this pull request Aug 7, 2022
Closed
@erikaldsund erikaldsund deleted the cpp17_filesystem_usage_fixes branch August 15, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@erikaldsund @dranikpg @The-EDev