only allow regular files in set_static_file_info, return 404 in all o… #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-EDev
requested changes
Jun 19, 2022
Contributor
Author
|
I defined the missing macro for windows as done in the SO discussion. On Linux this still compiles and works. |
The-EDev
reviewed
Jun 22, 2022
Member
The-EDev
left a comment
The-EDev
left a comment
There was a problem hiding this comment.
Aside from the comment I haven't tested the PR on windows, I'll try to get a VM running ASAP so I can do so.
Co-authored-by: Farook Al-Sammarraie <farook@the-e-dev.com>
The-EDev
approved these changes
Jun 23, 2022
Member
The-EDev
left a comment
The-EDev
left a comment
There was a problem hiding this comment.
Tested on windows, everything seems to be working as intended
Member
|
Merging now, thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #469
pathgiven toset_static_file_infoorset_static_file_info_unsafeis not a regular file return404.this->end()in the error case inset_static_file_info_unsafelocks crow, when the route-handler usesreturn response, because the completion-handler is called twice. Removing it, makes it work in all cases.