refactor(page-tree): reuse traversal selectors in form analysis#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
flattenSubtreefrom@core/page-tree.getParent, using the canonical parent index maintained by page-tree parsing/mutation boundaries.parentIdviareindexNodeParents, matching the production page-tree invariant.Why
Form publishing and editor-side form settings had their own tree traversal and parent lookup implementations. That duplicated logic bypassed the cycle-safe page-tree selector path and obscured the
parentIdsource-of-truth invariant.Impact
Form snapshot generation and form settings analysis now depend on the same page-tree selector primitives as the rest of the editor engine. The form-specific inference behavior is unchanged and covered by existing tests.
Verification
bun test src/__tests__/architecture/page-tree-single-source.test.tsred before implementation, then passingbun test src/__tests__/forms/formSnapshot.test.ts src/__tests__/forms/formSettingsAnalysis.test.tsbun run buildbun testbun run lint