refactor(site-import): reuse CMS media client#80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fetchcalls with the canonical CMS media persistence client.createSiteImportAdapter.Why
Site Import was duplicating the same media upload, folder listing, folder creation, and folder assignment behavior that the Media workspace already gets through
@core/persistence/cmsMedia. That made credentials, URL encoding, response validation, and error behavior easy to drift.Impact
Imported assets now ride the same validated CMS media client contract as the rest of the admin app. Folder assignment remains best-effort, so an assignment failure does not abort an otherwise successful asset upload.
Verification
bun test src/__tests__/admin/siteImport/createSiteImportAdapter.test.tsred before implementation, then passingbun test src/__tests__/architecture/boundary-validation.test.tsbun run buildbun testbun run lint