refactor(editor): split non-site workspace layout state#79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src/admin/state.uiSlice.AdminWorkspaceCanvasLayoutaway from@site/store/store.Why
Content/Data/Media were depending on the full Site editor store for generic shell state. That made the store boundary blurry and kept non-site workspace chrome coupled to Site-only panel concepts. This refactor gives shared workspace chrome its own admin-level owner while keeping Site editor layout persistence explicitly Site-scoped.
Impact
The immediate benefit is a cleaner dependency boundary: non-site workspace layout behavior can change without touching the Site editor store, and future store refactors have an executable import gate. Content/Data/Media still preserve their sidebar widths, right-panel state, and Data sidebar collapse state through the same
instatic-editor-layout-v2key.Verification
bun run buildbun run lintbun testbunx react-doctor@latest --verbose --scope changed --base main