chore(cleanup): dead-code spring cleanup — knip reports zero unused surface#41
Merged
Merged
Conversation
server/healthcheck.ts (Docker HEALTHCHECK), the QuickJS bootstrap sources (bundled via bootstrap:sync), the plugin admin-app surfaces (plugin-host-ui / plugin-host-hooks, loaded via dynamic import in pluginRuntimeBootstrap), the plugin SDK barrel + CLI, and server-side __tests__ are real entry points knip could not see. False-positive counts drop from 9/247/778 (files/exports/types) to 3/185/635 — the remainder is trustworthy dead surface. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
src/admin/layouts/index.ts, src/admin/modals/Settings/index.ts, and TypographyPanel/FontsSection/index.ts had zero importers — every consumer deep-imports the concrete files (admin barrels are convention-only, and these had drifted out of use entirely). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sweep of the verified dead surface flagged by the dead-code audit
(knip with the new entry-point config + per-symbol verification):
- src/core/publisher/render.ts: delete the backward-compat re-export shim
("kept importable so existing callers don't need to retarget" — nothing
imported through it anymore; back-compat shims are banned in this repo).
- server/publish/publicRouter.ts: un-export resolvePublicRoute /
publicSlugFromPath / PublicRouteResolution (internal-only callers).
- Delete dead API functions with zero callers: exportCmsBundle /
importCmsBundle (persistence), deleteUserPreference, updateCredential,
listDrivers, readDefaultForScope / clearDefaultForScope,
stopPublishScheduler, resetImageVariantWorkerPool,
_resetFontCachesForTests, isEditorWorkspaceId, countWireNodes,
isSafeFontPath — plus their now-orphaned schemas, constants, and types.
- Un-export ~180 exports and ~630 type aliases that nothing imports
(export keyword removed where the symbol is still used in-file; the
declaration deleted where it is fully dead). Constants that survived
only to derive a union type are inlined as literal unions
(stepUpPolicy, siteExplorer section ids, hookBus core events).
- Restore one knip false positive found by tsc: InsertionPresetNode is
type-imported through the module-picker barrel and stays exported.
Verified by the gates after every step: tsc strict, eslint, 5,343 tests,
vite build — all green. knip now reports 0 unused files / 0 exports /
0 types.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…g-cleanup # Conflicts: # server/publish/templateSeeding.ts # server/repositories/data/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Item 7 of the pre-1.0 health check. The raw audit said 9 unused files / 247 unused exports / 778 unused types — but a verification pass showed a big share were tool blind spots, and the rest was real dead surface accumulated across sessions. This PR fixes both: the tool config so future audits are trustworthy, and the actual dead code.
What changed (one commit per concern)
1.
knip.jsonlearns the real entry points.server/healthcheck.ts(run byDockerfile:53HEALTHCHECK), the QuickJS bootstrap sources (bundled to committed artifacts viabootstrap:sync), the plugin admin-app surfaces (plugin-host-ui/plugin-host-hooks, loaded via dynamicimport()inpluginRuntimeBootstrap.ts), the plugin SDK barrel + CLI, and server-side__tests__. This is what made fallow/knip claim@ui/components/Tabswas "100% dead" — it's re-exported by the plugin UI kit and very much alive.2. Three orphan admin barrels deleted — zero importers; consumers deep-import by design (
docs/editor.mdeven said so for layouts; doc updated).3. The sweep — knip now reports 0 unused files / 0 exports / 0 types.
src/core/publisher/render.ts: deleted the backward-compat re-export shim ("kept importable so existing callers don't need to retarget") — nothing imported through it, and back-compat shims are banned by CLAUDE.md.server/publish/publicRouter.ts: un-exportedresolvePublicRoute/publicSlugFromPath/PublicRouteResolution(internal-only; the architecture gates read source text, not imports).exportCmsBundle/importCmsBundle,deleteUserPreference,updateCredential,listDrivers,readDefaultForScope/clearDefaultForScope,stopPublishScheduler,resetImageVariantWorkerPool,_resetFontCachesForTests,isSafeFontPath, and friends.tscand restored:InsertionPresetNode(type-imported through the module-picker barrel).Net: 397 files, +636 / −1,103.
Verification
bunx tsc -b(strict) — cleanbun test— 5,343 pass / 0 failbun run lint,bun run build,bun run doctor— passbunx knip— 0 unused files, 0 unused exports, 0 unused typesThe pre-commit react-doctor notice on the sweep commit is the pre-existing warn-tier baseline (513+ repo-wide);
bun run doctor(the error-tier gate) exits 0.🤖 Generated with Claude Code