Remove inconsistent panel keyboard shortcuts from the rail#36
Merged
Conversation
The left-rail panel buttons advertised keyboard shortcuts in their tooltips (Site Ctrl+⇧E, Media Ctrl+⇧M, Properties Ctrl+⇧R, AI assistant ⌘I) but only 4 of ~10 rail panels had one, so the affordance was inconsistent and partly unwired. Drop the four panel-toggle keybindings entirely. - Remove the four `panels.toggle*` entries from the keybindings registry (keeping `panels.cycleFocus`/F6). - Drop the PanelRail keydown handler and the commandId → shortcut/aria derivation; rail buttons no longer render a shortcut hint or aria-keyshortcuts (plugin-supplied shortcutLabel is unaffected). - Drop PanelRail from the keybindings architecture-test allowlist — it no longer routes through the registry. - Update the layout tests that exercised the removed shortcuts. Panels remain toggleable from the command palette (the `panels.toggle*` spotlight commands are unchanged), which is consistent across all panels. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The left-rail panel buttons advertised keyboard shortcuts in their tooltips:
Ctrl+⇧ECtrl+⇧MCtrl+⇧R⌘IBut only 4 of ~10 rail panels had a shortcut — the other panels (Layers, Selectors, Colors, Typography, Spacing, Dependencies) had none. The affordance was inconsistent and not fully wired across the rail, so this PR removes all four panel-toggle shortcuts.
Changes
keybindings.ts— remove the fourpanels.toggle*registry entries (keepingpanels.cycleFocus/F6).PanelRail.tsx— drop thekeydownhandler and thecommandId → shortcut/ariaderivation. Rail buttons no longer render a shortcut hint in their tooltip oraria-keyshortcuts. Plugin-suppliedshortcutLabelis unaffected.keybindings-registry-single-source.test.ts— dropPanelRail.tsxfrom the allowlist; it no longer routes through the registry.editorLayoutPersistence.test.tsx— update the three tests that fired the removed shortcuts (now exercise the rail buttons / panel placement directly).Not changed
Panels stay toggleable from the command palette — the
panels.toggle*spotlight commands are untouched. Every panel already has a palette toggle command and none carry a keyboard shortcut, so this leaves the palette fully consistent.Verification
bun run build✅bun run lint✅bun testfor the touched layout + architecture + spotlight suites ✅🤖 Generated with Claude Code