fix(canvas): live mode shows the shared frame skeleton while hydrating#35
Merged
Merged
Conversation
The design canvas renders CanvasFrameSkeletonFrame per breakpoint when the page is null, but live mode showed a "No page selected" empty state during the same hydration window — reading like there was nothing to open. CanvasLiveSurface now renders the shared CanvasFrameSkeleton inside its own frame width model (breakpoint-keyed when only the page is pending, fluid during full hydration), so both views load consistently. The empty state is gone — design mode never had one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Design mode and live mode now load consistently. During site hydration, design mode shows the per-breakpoint
CanvasFrameSkeletonFrames — but live mode showed a "No page selected / Open a page to edit it live." empty state for the same window, which reads like there's nothing to open rather than something loading.How
CanvasLiveSurface's null-page branch now renders the sharedCanvasFrameSkeleton(the exact component the design frames use) inside the live frame's own width model:The empty state is deleted entirely — design mode never had one, and with
loadSitealways selecting a page there is no legitimate "site loaded but no page" state to represent.Testing
canvasLiveSurface.test.tsx: skeleton (witharia-busystatus semantics) renders while hydrating, keys to the active breakpoint when present, and the old empty-state copy is gone.docs/editor.mdcanvas-views section notes the shared loading treatment.bun test(5342 pass),bun run build,bun run lintall green.🤖 Generated with Claude Code