Clean up Style-rules review pane + fix icons:sync for in-house icons#31
Merged
Conversation
…marker, space the search The "Review import" step's Style-rules pane had three rough edges: - Every selector row carried an `ambient`/`class` badge — a distinction users don't act on. Removed the badge and collapsed `.ruleRow` to two columns so the selector name uses the full width. The underlying `rule.kind` still drives import behavior; only the UI noise is gone. - Converted-stylesheet mode rows crammed a `css` text chip into the 16px checkbox column, overflowing into a broken-looking box. Replaced it with a properly sized `FileTextSolidIcon` (`.fileBadge`). - The per-stylesheet mode rows sat flush against the "Search selectors…" bar. Gave them a dedicated `.modeRows` wrapper with bottom margin. Also fixed `scripts/sync-icons.ts`, which threw on any imported icon with no upstream source — breaking `bun run icons:sync` because of the hand-authored `strike` glyph (upstream ships `underline` but no strikethrough). Added an `IN_HOUSE_ICONS` allowlist that the upstream copy step skips while still asserting the vendored source exists. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tidies up the Review import → Style rules pane (the "Super Import" wizard) and fixes a latent break in
bun run icons:sync.Style-rules pane (
AnalyzeStep,StylesheetModeRows)ambient/classbadges on every selector row — a distinction users don't act on..ruleRowcollapses from 3 columns to 2 so the selector name uses the full width. The underlyingrule.kindstill drives import behavior; only the UI noise is gone.csschip on converted-stylesheet rows. It was a text chip crammed into the 16px checkbox column, overflowing its box. Replaced with a properly sizedFileTextSolidIcon(.fileBadge)..modeRowswrapper with bottom margin).scripts/sync-icons.tsbun run icons:syncthrew on any imported icon with no upstream source. The culprit is the hand-authoredstrikeglyph inBodyBubbleMenu(upstream pixel-art-icons shipsunderlinebut no strikethrough, so it was drawn in-house and committed tovendor/). The sync blindly tried to copy it from upstream and aborted.Added an
IN_HOUSE_ICONSallowlist that the upstream-copy step skips — while still asserting the vendored.tsxsource exists, so a deleted/renamed in-house icon still fails loudly.bun run icons:syncandbun run icons:checknow both pass (134 icons).Verification
bun run icons:sync✓ (134 icons) ·bun run icons:check✓ (fresh)bunx eslintclean on all four touched filesbun run buildpassed (run before the unrelated parallel work landed in the tree)Notes
no-giant-componentonAnalyzeStep(556 lines) — pre-existing; this PR removes lines rather than adding them. Splitting that component is out of scope.🤖 Generated with Claude Code