Stabilize flaky plugin sandbox infinite-loop abort test#18
Merged
Conversation
The test passed evalTimeoutMs=50, which also bounds the one-time bootstrap bundle compile inside createPluginVm. On a loaded CI runner that compile exceeded 50ms and was falsely interrupted, so createPluginVm threw before the runaway activate loop ran. Raise the budget to 1s (comfortably above worst-case bootstrap compile, still fast) and widen the elapsed assertion with slack so the regression coverage is timing-robust. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.0.3 release workflow's Verify job failed on one test:
aborts a plugin that hangs in an infinite loop. Root cause is a test-design flaw, not a product regression.The test passed
evalTimeoutMs: 50. That budget also wraps the one-time bootstrap-bundle compile insidecreatePluginVm(vm.ts:265). On the loaded CI runner the bootstrap compile exceeded 50ms and was interrupted, socreatePluginVmthrew before the runawayactivateloop ran (stack pointed at vm.ts:266 / withSyncDeadline, not the assertion). Locally bootstrap compiles in <50ms, so it always passed.Fix: raise the test budget to 1s (well above worst-case bootstrap compile, still fast) and widen the elapsed assertion with slack. The runaway loop still aborts within the budget. Ran the test 3× locally — deterministic.
🤖 Generated with Claude Code