feat: Add Qwen Code client configurator#835
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@MCPForUnity/Editor/Clients/Configurators/QwenCodeConfigurator.cs`:
- Line 33: Update the incorrect npm package string in the QwenCode installation
hint: replace the reference to "@anthropic-ai/qwen-code" with the correct
Alibaba package "@qwen-code/qwen-code" inside the QwenCodeConfigurator (the
installer/help message string shown in the configurator code) so the displayed
installation instruction matches the PR description.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
MCPForUnity/Editor/Clients/Configurators/QwenCodeConfigurator.csMCPForUnity/Editor/Clients/Configurators/QwenCodeConfigurator.cs.meta
Contributor
Reviewer's GuideAdds a new JsonFileMcpConfigurator-based client configurator to integrate Qwen Code as a configurable MCP client in the Unity MCP window, including installation/setup guidance and cross-platform settings.json path resolution. Class diagram for QwenCodeConfigurator and related typesclassDiagram
title Class diagram for QwenCodeConfigurator and related types
class JsonFileMcpConfigurator {
+McpClient client
+JsonFileMcpConfigurator(McpClient client)
+IList~string~ GetInstallationSteps()
}
class QwenCodeConfigurator {
+QwenCodeConfigurator()
+IList~string~ GetInstallationSteps()
}
class McpClient {
string name
string windowsConfigPath
string macConfigPath
string linuxConfigPath
bool SupportsHttpTransport
}
QwenCodeConfigurator --|> JsonFileMcpConfigurator
JsonFileMcpConfigurator --> McpClient : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The config file path is repeated three times for different platforms; consider extracting a shared helper or constant to avoid duplication and make future path changes less error-prone.
- In
GetInstallationSteps, the hardcoded~/.qwen/settings.jsonpath may be confusing on Windows; you could derive this path using the sameEnvironment.GetFolderPathlogic used in the configurator to keep instructions platform-accurate.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The config file path is repeated three times for different platforms; consider extracting a shared helper or constant to avoid duplication and make future path changes less error-prone.
- In `GetInstallationSteps`, the hardcoded `~/.qwen/settings.json` path may be confusing on Windows; you could derive this path using the same `Environment.GetFolderPath` logic used in the configurator to keep instructions platform-accurate.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Qwen Code (https://github.com/QwenLM/qwen-code) as a configurable MCP client in the Unity MCP window.
Qwen Code is an AI-powered CLI coding assistant by Alibaba that supports MCP servers for tool integration.
Changes
QwenCodeConfigurator.cs- Client configurator for Qwen CodeQwenCodeConfigurator.cs.meta- Unity meta file~/.qwen/settings.jsonJsonFileMcpConfiguratorbase classInstallation
Users can install Qwen Code via:
Testing
Related Issues
None
Checklist
Summary by Sourcery
Add a configurable MCP client integration for Qwen Code in the Unity MCP window.
New Features:
Documentation:
Summary by CodeRabbit