Repository navigation
Discard conversation titles that arrive after deletion - #926
Merged
davidmckayv merged 4 commits intoNov 2, 2026
Merged
davidmckayv merged 4 commits into
davidmckayv merged 4 commits into
Conversation
Implemented and locally validated with OpenAI Codex assistance.
rudycelekli
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
October 31, 2026 06:18
Brings the branch up to date with main.
Unreleased opens with the Before upgrading list, and the entries for each change follow it. The entry sat above that list; it now leads the entries after it.
…uring-model-20261031 # Conflicts: # CHANGELOG.md
davidmckayv
approved these changes
Nov 2, 2026
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Checked together with the other fixes on one tree with the full test suite, and merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Conversation naming checks whether a channel was deleted before asking the model. If deletion happens while that model call is pending, the final write can still add a summary to the soft-deleted row and announce it to the channel's members. A hard-deleted channel is also reported as successfully named even though no row changed.
Recheck
deletedAtin the conditional write. If no row changes, distinguish a surviving channel another writer named from a channel that is gone. Both settle their queue item, while a deleted channel gets no new summary, timestamp, or summary announcement.Where it runs
Boundary and audit
Changelog
Proof
Base
743649efc3f21d7bf0badbe6af2bcd5daedd97ce, headc0f3c577ccbabe91d7d1f0740d4cfce1c62e265d.Two regressions pause the model with a promise barrier while the real worker holds a queue claim, perform a soft or hard deletion in Postgres, then release the title. Before: both fail. A real
LISTENconnection captures the late summary announcement after soft deletion; hard deletion is incorrectly listed as written. After: the deleted row is unchanged or absent, neither job reports a successful name, both jobs finish, and no summary announcement is emitted. A commit-orderedNOTIFYmarker confirms the listener observed the completed transaction; no timing sleeps or live model calls are used.The full channel-summary file passes 19 tests and 47 assertions. All 10 channel and work-queue files pass together: 206 tests, 503 assertions. Controls retain another writer's existing title, ordinary naming, concurrent claims, delayed transcripts, model-failure retries, and notification size limits.
Format, lint, workspace typecheck, the test-typecheck baseline guard, and build pass on this exact head.
The full suite was not run on this head. A separate routing candidate (
d428f669f10e21700b6d5eb1fb14e90c9cc59cfe) on the same base ran fulltest:ci: 11,017 passed, 210 skipped, two failed (routine-sweep concurrency expectation and recorder held-steps service-worker timing). Both passed when isolated on unchanged base and that routing candidate; full-suite order/timing causality remains unresolved.The tests use a dedicated disposable PostgreSQL 15 database (hosted CI uses 17), with no application data or live provider calls. PRs #917 and #918 change task-brief unwrapping in a different part of this file; they do not change this final write.
AI assistance: implemented and locally validated with OpenAI Codex. Hosted CI and maintainer review remain required.