Skip to content

Conversation

@alanmcanonical
Copy link
Contributor

Description:

  • Implement rule 5.3.3.2.6 Ensure password dictionary check is enabled

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.3.3.2.6
@alanmcanonical alanmcanonical requested a review from a team as a code owner December 19, 2024 11:49
@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 19, 2024
@github-actions
Copy link

github-actions bot commented Dec 19, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 154950a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Dec 19, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Dec 19, 2024
@dodys dodys added this to the 0.1.76 milestone Dec 19, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit b9e7548 into ComplianceAsCode:master Dec 19, 2024
126 of 133 checks passed
@alanmcanonical alanmcanonical deleted the ubt24_53326 branch April 24, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

2 participants