Add version to profile element in the data stream #10909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Contributor
|
/packit retest-failed |
jan-cerny
reviewed
Jul 31, 2023
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
This is great!
We need a test for this feature.
It would be nice to fix the code complexity although it's been very complex before.
Mab879
force-pushed
the
add_version_profile_datastream
branch
from
a9d17a2 to
4f55423
Compare
|
Code Climate has analyzed commit 4f55423 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Aug 1, 2023
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I have built the data stream and I have viewed the version elements and their contents.
Thanks for this change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds version numbers for profiles to the data stream based on the metadata version information.
Rationale:
To aid in future features.
Review Hints:
./build_product -j10 rhel8grep xccdf-1.2:version build/ssg-*-ds.xml