Skip to content

Do not send email too frequently #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Do not send email too frequently #1994

merged 1 commit into from
Nov 25, 2020

Conversation

@majecty
Copy link

@majecty majecty commented Nov 25, 2020

No description provided.

@majecty majecty requested a review from junha1 November 25, 2020 02:15
junha1
junha1 approved these changes Nov 25, 2020
View reviewed changes
util/logger/src/logger.rs
None => false,
};
if !sent_recently {
email_alarm.send(&format!("{} {} {}", thread_name, log_target, log_message));
Copy link
Contributor

@junha1 junha1 Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that this doesn't cause another log. It will lead to a deadlock. If not, LGTM.
Copy link
Author

@majecty majecty Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The send function does not use log.
@majecty
Copy link
Author

majecty commented Nov 25, 2020

The test succeeds in my local machine.
@majecty majecty merged commit 6e67d80 into CodeChain-io:rc-2.2.x Nov 25, 2020
@majecty majecty deleted the f/mail-log-limit branch November 25, 2020 05:06
@majecty majecty mentioned this pull request Nov 25, 2020
Merged
@majecty majecty mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@majecty @junha1