Skip to content

Remove the bundler with clean, it seems to work fine without on later releases of bundler - #9

Open
orta wants to merge 1 commit into
masterfrom
unbundle
Open

Remove the bundler with clean, it seems to work fine without on later releases of bundler#9
orta wants to merge 1 commit into
masterfrom
unbundle

Conversation

@orta

@orta orta commented Dec 1, 2016

Copy link
Copy Markdown
Member

I couldn't use any rake commands because of errors like:

screen shot 2016-12-01 at 09 53 00

Removing the with_clean_env fixed it 👍
@segiddins

segiddins commented Dec 1, 2016

Copy link
Copy Markdown
Member

I'm afraid this might actually break things, as running bundle install once BUNDLE_GEMFILE is set won't pick up the gemfile in the subdirectory
segiddins
segiddins reviewed Dec 1, 2016
View reviewed changes
Comment thread Rakefile
Bundler.with_clean_env do
puts `bundle install`
end
puts `bundle install`

@segiddins segiddins Dec 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be sh "bundle install"

@orta orta Dec 1, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah - yeah
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@orta @segiddins