[pull] main from NREL:main#11
Merged
pull[bot] merged 13 commits intoBluejacketScott:mainfrom Jun 13, 2025
Merged
Conversation
I'd like to revisit the Renovate setup in the future for better automation, but our build checksums and repo permissions make this a bit trickier, so for now, just try to automate the manual update process a bit.
When we first started this envoy didn't provide pre-built binaries, which is why we had to hop through using crane to extract it from the docker image. But now that Envoy does provide binaries, just download those directly to eliminate a dependency.
If an API backend is configured to allow for anonymous access without API keys, then there are some options to allow the authenticated rate limits only use the API key limits and not the IP limits. However, due to some caching of when an IP exceeds rate limits, this could still lead to a user with an API key being blocked once the IP exceeded the configured anonymous limit for the IP. The bug was due to the caching mechanism to check for cached rate limit exceedings looping over all possible rate limits, and not excluding these limits that we don't actually increment. The increment logic was properly skipping over the non-applicable rate limits, so we just needed to shift where the check for non-applicable limits was being applied so it got applied to all loops when checking for rate limits, not just in certain areas. As part of this, this also refactors some of the rate limit test helpers to use keywoard arguments so it's a little more obvious what methods use what arguments, rather than a big hash of optional values being passed around. The need to filter these makes this perhaps still a little clunky, but I was having a hard time tracing things originally, so hopefully this will make it easier.
Not totally sure of the root cause, but hitting these same `Class extends value undefined is not a constructor or null` errors in CI browser tests with the newer version as noted here: embroider-build/embroider#2440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )