Skip to content

Adding Docker Support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding Docker Support #11

wants to merge 1 commit into from

Conversation

@arcsector
Copy link

@arcsector arcsector commented Jul 23, 2019

Purpose

ssdeep is a hassle to install on systems and the configuration can take way too long. Using docker, we can run this on a container platform in the cloud or even locally as a service. Logging results is easy with the docker logging driver.

Changes

Adding:

  • Dockerfile
  • .gitignore

Changes:

  • README.md
    • Adding docker instructions for building and running
  • gitgot.py
    • Adding fully qualified path to line 288 if user is not running python file from current directory
Adding:
b52454c 
- Dockerfile
- .gitignore

Changes:
- README.md
  - Adding docker instructions for building and running
- gitgot.py
  - Adding fully qualified path to line 288 if user is not running python file from current directory
@the-bumble
Copy link
Contributor

the-bumble commented Jul 24, 2019

Hi arcsector,

Thank you for your changes! Sorry, I was working on Docker support with another contributor before this submission came in :( Our resulting alpine-based docker image came in at 135MB v.s. this 472MB debian-based image, so we managed to shrink the image-size requirements a bit!

I'm curious for your thoughts on the solution we arrived at. Feel free to send a PR / file an issue if you have any suggested changes/concerns.

Thank you!
@the-bumble the-bumble closed this Jul 24, 2019
@arcsector
Copy link
Author

arcsector commented Jul 24, 2019 •
edited
Loading

All good; just saw a need and worked to fill it. Only thing i would recommend is to put your dependecies in a directory or a static location; for legacy purposes if the code ever evolves it could break functionality with either python-ssdeep or with ssdeep itself. Regardless, cant wait to see this on dockerhub.
@arcsector
Copy link
Author

arcsector commented Jul 24, 2019

And side note, the reason i was using debian is because thats what the creator of python-ssdeep is using for his docker container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@arcsector @the-bumble