Changes forNew Antd Components and Refactor Ones #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruxcode
reviewed
Mar 15, 2023
| import { CssSummary } from "./components/cssSummary/CssSummary"; | ||
| import { Tree } from "@atrilabs/forest"; | ||
| import { BoxShadow } from "./components/box-shadow/BoxShadow"; | ||
| import {ListStyle} from "./components/list-style/ListStyle"; |
Collaborator
There was a problem hiding this comment.
Why is your linter not working? There must be a gap in between like this{ ListStyle }.
| } | ||
| >((props, ref) => { | ||
| const { custom } = props; | ||
| console.log("disabled is", props.custom.disabled); |
| e.stopPropagation(); // stop event propagation | ||
| return; | ||
| } else { | ||
| console.log("else"); |
| () => <img src={props.custom?.expandIcon} alt={props.custom?.expandIcon} />, | ||
| [props.custom] | ||
| ); | ||
| console.log("items", props.custom.items); |
| ); | ||
| const { custom } = props; | ||
| const onChange = (currentSlide: number) => { | ||
| console.log(currentSlide); |
Collaborator
There was a problem hiding this comment.
I think you should attach an onChange callback to the manifest of Carousel and call that here.
| children: React.ReactNode[]; | ||
| } | ||
| >((props, ref) => { | ||
| console.log("props.styles", props.styles); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Add reference to a related issue that this pull request is addressing. For example, fixes #
Describe the pull request
Please describe the changes proposed in this pull request.
Contributors (in case of a commit with multiple authors)
Co-authors: