Implemented visual hints while dragging components #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruxcode
reviewed
Mar 12, 2023
| window.parent.postMessage( | ||
| { type: "moveWhileDrag", id: context.probableParent }, | ||
| "*" | ||
| ); |
Collaborator
There was a problem hiding this comment.
Don't post moveWhileDrag because sending messages is costly. The moveWhileDrag is continuous process and will bombard the message channel.
cruxcode
reviewed
Mar 12, 2023
cruxcode
reviewed
Mar 12, 2023
| }, | ||
| [DROPZONE_CREATION_IN_PROGRESS]: { | ||
| actions: ["emitDropzoneCreationInProgress"], | ||
| }, |
Collaborator
There was a problem hiding this comment.
We don't need this anymore.
cruxcode
reviewed
Mar 12, 2023
| [REDROP_FAILED]: [], | ||
| [SELECT]: [], | ||
| [SELECT_END]: [], | ||
| [DROPZONE_CREATION_IN_PROGRESS]: [], |
Collaborator
There was a problem hiding this comment.
Add two subscribers - DROPZONE_CREATED and DROPZONE_DESTROYED.
* bugfix: before_app_load to unset the comp id state * handleBreakpointChange & bugfix * removed console.log * select overlay done * overlay for hover done * bugfix: update hovered on re-hoverWhileSelected * removed console.log * overlay on reposition * python files are generated from react manifest * generate __init__.py file * atri_core is publishable * python manifest project built using package.json * bugfix: call join after map * wip: generate python model for each page * python page model gets generated * generate python models in dev mode * dev mode for generate python routes done * create alias on drop done * change alias using aliasApi done * action layer added * bugfix: add .jsx random extension for IRToUnixFilepath to work * removed canvas-zone-manager package * support for shared libs in tool * asset manager integrated * removed react-shim manifest-shims packages * resource layer integrated * imported fonts reflect in editor * bugfix: remove duplicate import * manifest in example-atri-app populates in editor & app * removed install-scripts * createComponentManifest done * build editor for production * pwa-builder-server serves pwa-builder * @atrilabs/new package invoked to create a new atri app * changes main to bin * page scaffold includes canvas zone * expose pwa-builder-server binary & new package * package.json version set to 1.0.0-alpha.0 * removed app-scripts & app-generator package * removed webapp-builder package * removed scripts * removed packages not to be shipped in 1.0.0-alpha.0 * installed missing dependencies * package.json updated * v1.0.0-alpha.0 * fix: serve manifest registry * fixes: updated missing deps in create-atri-app * __version__ set to 1.0.0-alpha.1 * v1.0.0-alpha.1 * fix: pwa-builder build command without manifests * v1.0.0-alpha.2 * fix: use uuid vs @atrilabs/core * v1.0.0-alpha.3 * new parameters inside quotes * v1.0.0-alpha.4 * copy-paste inside component done * canvas zone as paste target done * up/down arrow key works * create component undo/redo done * wip: undo-redo * undo-redo done * wip: component navigator data compute done * wip: component navigator update on alias change * component navigator open close done * patchCb called on comp navigator reposition * raise hover & select from comp navigator * select on reposition/rewire end * fix: sort the direct child of canvas * __version__ set to 1.0.0-alpha.5 * v1.0.0-alpha.5 * yarn editor register new components from manifests dir * build manifest python packages inside manifests done * build manifest python packages inside manifests done * wip: wiring for fetching user events done * wip: live canvas zone with components done * live canvas zone with components done * callbacks attached in live mode * wip: hook with python * /_atri/api/event request is sent to python * handle event updates live view * fix: make sure alias patch is sent later * bugfix: drag-drop disappearing * bugfix: new dragged node is set on togglenode * atri-comp-id & atri-parent-marker assigned * overlays adapted for repeating list * removed log statement
* bugfix: before_app_load to unset the comp id state * handleBreakpointChange & bugfix * removed console.log * select overlay done * overlay for hover done * bugfix: update hovered on re-hoverWhileSelected * removed console.log * overlay on reposition * python files are generated from react manifest * generate __init__.py file * atri_core is publishable * python manifest project built using package.json * bugfix: call join after map * wip: generate python model for each page * python page model gets generated * generate python models in dev mode * dev mode for generate python routes done * create alias on drop done * change alias using aliasApi done * action layer added * bugfix: add .jsx random extension for IRToUnixFilepath to work * removed canvas-zone-manager package * support for shared libs in tool * asset manager integrated * removed react-shim manifest-shims packages * resource layer integrated * imported fonts reflect in editor * bugfix: remove duplicate import * manifest in example-atri-app populates in editor & app * removed install-scripts * createComponentManifest done * build editor for production * pwa-builder-server serves pwa-builder * @atrilabs/new package invoked to create a new atri app * changes main to bin * page scaffold includes canvas zone * expose pwa-builder-server binary & new package * package.json version set to 1.0.0-alpha.0 * removed app-scripts & app-generator package * removed webapp-builder package * removed scripts * removed packages not to be shipped in 1.0.0-alpha.0 * installed missing dependencies * package.json updated * v1.0.0-alpha.0 * fix: serve manifest registry * fixes: updated missing deps in create-atri-app * __version__ set to 1.0.0-alpha.1 * v1.0.0-alpha.1 * fix: pwa-builder build command without manifests * v1.0.0-alpha.2 * fix: use uuid vs @atrilabs/core * v1.0.0-alpha.3 * new parameters inside quotes * v1.0.0-alpha.4 * copy-paste inside component done * canvas zone as paste target done * up/down arrow key works * create component undo/redo done * wip: undo-redo * undo-redo done * wip: component navigator data compute done * wip: component navigator update on alias change * component navigator open close done * patchCb called on comp navigator reposition * raise hover & select from comp navigator * select on reposition/rewire end * fix: sort the direct child of canvas * __version__ set to 1.0.0-alpha.5 * v1.0.0-alpha.5 * yarn editor register new components from manifests dir * build manifest python packages inside manifests done * build manifest python packages inside manifests done * wip: wiring for fetching user events done * wip: live canvas zone with components done * live canvas zone with components done * callbacks attached in live mode * wip: hook with python * /_atri/api/event request is sent to python * handle event updates live view * fix: make sure alias patch is sent later * bugfix: drag-drop disappearing * bugfix: new dragged node is set on togglenode * __version__ set to 1.0.0-alpha.6
… and not needed in the canvasMachine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Add reference to a related issue that this pull request is addressing. For example, fixes #719
Describe the pull request
Please describe the changes proposed in this pull request.
This PR intends to add visual hints to show the probable parent
Contributors (in case of a commit with multiple authors)
Co-authors: