Antd components Button and Input #695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptitiwari2917
force-pushed
the
main
branch
from
31b5637 to
9158efa
Compare
cruxcode
reviewed
Mar 1, 2023
| useEffect(() => { | ||
| const ref = componentStoreApi.getComponentRef(props.id); | ||
| ref.current?.setAttribute("data-atri-comp-id", props.id); | ||
| ref?.current?.setAttribute("data-atri-comp-id", props.id); |
Collaborator
There was a problem hiding this comment.
I am expecting ref not to be null here. I guess we don't need this change.
cruxcode
reviewed
Mar 1, 2023
| Search:{}, | ||
| Select:{}, | ||
| Typography:{}, | ||
| Title:{}, |
Collaborator
There was a problem hiding this comment.
We don't need packages/component-tree-to-app package anymore. Hence, no need to update it.
cruxcode
reviewed
Mar 1, 2023
| modulePath: "./src/manifests/Select/Select.tsx", | ||
| exportedVarName: "Select", | ||
| }, | ||
| Typography:{ |
Collaborator
There was a problem hiding this comment.
We don't need to update the manifest.config.js file anymore. I will actually remove this exported object from manifest.config.js file.
cruxcode
reviewed
Mar 1, 2023
| styles: React.CSSProperties; | ||
| custom: { | ||
| alertType: string; | ||
| alertType: AlertType; // | string; |
Collaborator
There was a problem hiding this comment.
Remove the commented part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Add reference to a related issue that this pull request is addressing. For example, fixes #
Describe the pull request
Please describe the changes proposed in this pull request.
Contributors (in case of a commit with multiple authors)
Co-authors: