Skip to content

Added enum type in custom props #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Added enum type in custom props #485

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4cd6ff
Added enum type in custom props
jonathanalvares9009 Oct 29, 2022
f21720f
Changed alert type from text to enum
jonathanalvares9009 Oct 29, 2022
3fbd45f
Changed the layout of elements in Alert component
jonathanalvares9009 Oct 29, 2022
97a45a0
Removed code as per code review
jonathanalvares9009 Oct 30, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed alert type from text to enum
  • Loading branch information
@jonathanalvares9009
jonathanalvares9009 committed Oct 29, 2022
commit f21720f9ef0d49d25769ef7b25e6aa9d32f9861c
6 changes: 4 additions & 2 deletions packages/react-component-manifests/src/manifests/Alert/Alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ const cssTreeOptions: CSSTreeOptions = {

const customTreeOptions: CustomPropsTreeOptions = {
dataTypes: {
alertType: { type: "text" },
alertType: {
type: "enum",
options: ["success", "info", "warning", "error"],
},
title: { type: "text" },
description: { type: "text" },
successIcon: { type: "static_asset" },
Expand Down Expand Up @@ -153,7 +156,6 @@ const compManifest: ReactComponentManifestSchema = {
custom: {
treeId: CustomTreeId,
initialValue: {
alertType: "success",
title: "Alert Title",
description: "Alert Description",
isClosable: true,
Expand Down