Skip to content

Reorder members to resolve build warning #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kegilbert wants to merge 1 commit into from
Closed

Reorder members to resolve build warning #7906

kegilbert wants to merge 1 commit into from

Conversation

@kegilbert
Copy link
Contributor

@kegilbert kegilbert commented Aug 27, 2018

Description

Reorder fixes warning about ctor setup for member variables:

Compile [ 75.0%]: InternetSocket.cpp                                                                          
[Warning] InternetSocket.h@235,10: 'InternetSocket::_factory_allocated' will be initialized after [-Wreorder] 
[Warning] InternetSocket.h@234,23:   'volatile unsigned int InternetSocket::_pending' [-Wreorder]             
[Warning] InternetSocket.cpp@22,1:   when initialized here [-Wreorder]

In response to: #7885

Also related: #7886

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@kegilbert
Reorder members to resolve build warning
f032830 
reorder fixes warning about ctor setup for member variables
@kegilbert kegilbert requested a review from SeppoTakalo August 27, 2018 22:14
@0xc0170 0xc0170 requested a review from a team August 28, 2018 06:51
@juhaylinen
Copy link
Contributor

juhaylinen commented Aug 28, 2018

Another PR to fix the same warning #7883
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2018

Another PR to fix the same warning #7883

That is correct. as that one is already in CI. Let's close this one.
@0xc0170 0xc0170 closed this Aug 28, 2018
@0xc0170 0xc0170 removed the needs: CI label Aug 28, 2018
@0xc0170 0xc0170 deleted the internetsocket-warn-patch branch September 27, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@kegilbert @juhaylinen @0xc0170 @SeppoTakalo