upkeep/102: bump min WP and PHP versions#111
Merged
Sidsector9 merged 8 commits intodevelopfrom Jan 17, 2023
Merged
Conversation
Sidsector9
requested review from
a team and
cadic
and removed request for
a team
cadic
previously approved these changes
Oct 31, 2022
Contributor
|
@Sidsector9 do you think we can also add PHP version in composer config: https://getcomposer.org/doc/06-config.md#platform |
Sidsector9
force-pushed
the
upkeep/102
branch
from
292980d to
44431c8
Compare
cadic
suggested changes
Nov 2, 2022
Contributor
cadic
left a comment
cadic
left a comment
There was a problem hiding this comment.
The .nvmrc file is empty, shouldn't we specify Node version?
Sidsector9
force-pushed
the
upkeep/102
branch
from
941d352 to
47906a2
Compare
cadic
suggested changes
Nov 7, 2022
Contributor
cadic
left a comment
cadic
left a comment
There was a problem hiding this comment.
@Sidsector9 After the latest change, both 3 e2e test workflows fail at the "Build" step, which looks unsafe for the future automated release workflows. Could you please check what was going wrong there?
cadic
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #102
Changelog Entry
Credits
Props @vikrampm1 @Sidsector9
Checklist: