Conversation
|
@s3rgiosan Apologies for the ping here after this is already merged but in doing final testing today in advance of doing a release (#263) I noticed that if I set a custom icon color, that shows properly in the editor but doesn't show on the front-end (which I must have missed when testing this previously). It seems on the front-end (in Wondering if you have time to open a new PR to address this to help unblock the release? |
|
@dkotter I'll work on a fix as soon as possible |
|
@dkotter This was addressed here. I reverted the change that added the icon color. While using the icon color makes more sense than relying on the text color for the SVG, the goal here was to unblock this release. We can revisit and properly add icon color support later, including fallback to text color. Let me know if you'd prefer to hold off and address the icon color implementation before releasing the new version. |
Description of the Change
This PR adds a new "Icon color" setting, allowing editors to control the SVG fill color. It also removes text color support, as it's redundant in this icon-specific context.
Before
After
How to test the Change
Changelog Entry
Credits
Props @s3rgiosan
Checklist: