Fix: Issue 97 - NPM Archive Distribution#220
Merged
peterwilsoncc merged 4 commits into10up:developfrom Aug 28, 2024
Merged
Conversation
peterwilsoncc
approved these changes
Aug 28, 2024
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
This looks good to me and tests well. I've attached a copy of the zip as a record of what's generated. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
archiveconfig incomposer.jsonto ignore files & directories fromcomposer archivecommand.pre-archive-cmdpost-archive-cmd.gitattributesfrom Stop distributing development files #143Closes #97
How to test the Change
npm install && composer install && npm run buildnpm archiveand observe the bundled files.node_modules/vendor/directory without any dev dependencies/vendor/directory and confirm dev dependencies have been re-installed.Changelog Entry
Credits
Props @TylerB24890 , @peterwilsoncc , @szepeviktor
Checklist: