Update how custom svg dimesions are applied

[gabriel-glo]

Description of the Change

• Update how custom svg dimesions are applied for get_image_tag and wp_get_attachment_image functions
• Separate the logic for defining custom dimensions in a set_svg_dimension function

Closes #6

How to test the Change

In any template output the image markup either by using get_image_tag or wp_get_attachment_image functions.
Set the custom image size to either one of the registered image size names or a custom one via array [$width, $height].
Output should match the set dimensions.

Changelog Entry

Added - added set_svg_dimension function in order to reduce repetition
Changed - changed how image dimensions were passed in get_image_tag_override and one_pixel_fix methods

Credits

Props @gabriel-glo, @jeremymoore, @iamdharmesh, @dkotter

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[github-actions]

@gabriel-glo thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

[iamdharmesh]

Thanks a lot for the PR @gabriel-glo. Code looks good and it tests well. (Added one minor doc update suggestion)

@dkotter The PR looks good to me. However, since we had 2-3 size/dimension-related PRs on this plugin earlier and you have better context on those, I wanted to have a quick review from your side to ensure these changes align with those PRs.

Thank you.

[dkotter]

This looks good to me now. Tested with both get_image_tag and wp_get_attachment_image and verified things worked as expected with both. Testing on the latest release and on this PR, get_image_tag returns the exact same output. Testing wp_get_attachment_image, on the latest release, if you pass in an array of sizes, those values aren't being used. On this PR, those sizes are now respected and set properly as the height and width attributes.

[martinpl]

This breaks behavior in wp_get_attachment_image():
before: any thumbnail size will inherit SVG width, height attributes
now: only 'full' thumbnail will inherit SVG width, height attributes

Reverting this helps:
https://github.com/10up/safe-svg/pull/216/files#diff-05bf19b873cfb6358cd7c239366db6675635bf4b03a4b56353102e359d5c2859L447