Problem/Motivation

Procedural handler access callbacks have been deprecated.
Default to false if they exist afterwards to prevent leaking data.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3547724

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented

This may be good to start?

nicxvan’s picture

nicxvan commented
Title: [pp-d12] Set the default access callback unsupported procedural functions to FALSE » Set the default access callback unsupported procedural functions to FALSE

Yes

smustgrave opened merge request !15272

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
Related issues: +#3553503: [meta] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules from Drupal 12

Is that what you meant? Wasn't entirely sure what needed to be removed.

starting to go back through any deprecations we moved to follow ups and this was one.

nicxvan’s picture

nicxvan commented
Issue tags: +Needs subsystem maintainer review

Looking at the intent I think we need to also drop: && function_exists($this->definition['access callback'])
The access callback looks like it only supported procedural implementations, and we need to not accidentally grant access where we didn't previously.

I may be mistaken here so I tagged for subsystem review too.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Lets do the approach @berdir mentioned.