Add option to have default setting for providing menu link

There was an issue with the functionality, so fixed that and added tests.

The current MR was created against 9.5x and I don't have permission to edit, so created patch

This seems close but I don't see where we are testing that the menu link is pre-checked on the node add page.

Also will need a change record with appropriate screenshots.

Hi, I updated the tests, I hope this will be enough

Change record - https://www.drupal.org/node/3373587

Think this is better

+++ b/core/modules/menu_ui/config/schema/menu_ui.schema.yml
@@ -21,3 +21,6 @@ node.type.*.third_party.menu_ui:
+    link_by_default:

Given the schema change, wouldn't this need an upgrade path?

Closed #1440694: Add a menu item for each "Basic page" by default (Standard install profile) as a duplicate

Excellent idea, lets do this. Two questions:

- Provide or create? Maybe create is the simpler word? Lets also add 'a': Create a new menu item by default.
- Was this deliberately put at the bottom of this list of settings? I can also imagine it at the top, as the very first consideration and decision to make for this menu settings section.

- Provide or create?

"Provide" is the word used in the Menu settings on the node edit form, so it might be best to keep the words consistent.

"Provide a menu link by default."
-OR-
"Provide a menu link by default when saving new content."
-OR-
"Provide a menu link by default when saving new content of this type." - My vote, fwiw

The "...content of this type" phrase comes from two other places:

"Content of this type can be placed in the selected menus."

"This text will be displayed at the top of the page when creating or editing content of this type."

The word "Add" would also make sense as it is used throughout the UI, but between the 3 proposed options (Provide, Create, Add) I'd personally vote for consistency and stick with "Provide", unless we want to change the word "Provide" to something else on the node edit form.

Note: whichever sentence ends up being used it needs a . (period) at the end of the sentence.

- Was this deliberately put at the bottom of this list of settings?

I think it make most sense either right above or right below the Default parent link select list as the two are related.

The MR looks good overall but I think the testing could be easily extended to check if the link was actually created at admin/structure/menu/manage/main

Seems additional test coverage has been added in commit https://git.drupalcode.org/project/drupal/-/merge_requests/4642/diffs?co...

See the comment on the MR - we need to rewrite the post update.

Hiding all the files to make this easier to review.

+1 for putting it at the top.
I get what Chris Matthews is saying but in natural order I would say something like: "Oh definitely create a menu item by default, these are the menus I would like available, but the default one should be this." That feels right to me.

Closed #3405645: Auto create the menu for node. as a duplicate of this.

Triaging this one

First this needs an issue summary update.

Let me try and get a main branch up for review.

Believe this is ready for review.