onActivityResult() not called when Activity started from Fragment

Question

I have an issue with importing a picture from the Album in Android, because the onActivityResult() method is never called.

This is the code that I wrote (called from a fragment not an activity):

Intent galleryIntent = new Intent(Intent.ACTION_PICK,  android.provider.MediaStore.Images.Media.EXTERNAL_CONTENT_URI);
getActivity().startActivityForResult(galleryIntent, PICK_IMAGE);

And by the way, I have defined the onActivityResult() but it's never triggered:

@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
    Log.d(TAG, "onActivityResult"); // not printed
}

Any idea what's wrong with this?

Thanks!

add constructor , super.onActivityResult(requestCode, resultCode, data); — Venky
– Venky, Commented Jan 12, 2012 at 17:30
I have edited the question, indeed my code has already that line. — Amokrane Chentir
– Amokrane Chentir, Commented Jan 12, 2012 at 17:39
Intent intent = new Intent(Intent.ACTION_GET_CONTENT, null); intent.setType("image/*"); intent.putExtra("return-data", true); startActivityForResult(intent, 1); — Venky
– Venky, Commented Jan 12, 2012 at 17:45

gnobal · Accepted Answer · 2012-03-17 12:08:47Z

112

To have onActivityResult() called in the fragment, you should call the fragment's version of startActivityForResult(), not the activity's. So in your fragment's code, replace

getActivity().startActivityForResult(galleryIntent, PICK_IMAGE);

with

startActivityForResult(galleryIntent, PICK_IMAGE);

answered Mar 17, 2012 at 12:08

gnobal

18.5k4 gold badges34 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Kuffs Over a year ago

So easy to make that mistake when converting Activities to Fragments :-)

Javier Over a year ago

WOW worked :) nice, we always use getActivity() in fragments :) help me a lot

irwinb Over a year ago

this should be the correct answer, the other method of calling a method inside your fragment is a workaround

Damian Walczak Over a year ago

I lost some time trying to figure it out. Thanks for the answer! :)

jegumi · Accepted Answer · 2012-01-12 22:59:09Z

With this code:

Intent galleryIntent = new Intent(Intent.ACTION_PICK, android.provider.MediaStore.Images.Media.EXTERNAL_CONTENT_URI);
getActivity().startActivityForResult(galleryIntent, PICK_IMAGE);

The onActivityResult must be in the Activity that contains the Fragment. From there you can call any method of the fragment, not in the fragment.

MyFragment myFragment = (MyFragment) getSupportFragmentManager().findFragmentById(R.id.fragment);
myFragment .onCameraResult(requestCode, resultCode, intent);

to do there whatever you want

Venky · Accepted Answer · 2012-01-12 17:47:50Z

Try this Snippet :

    Intent intent = new Intent(Intent.ACTION_GET_CONTENT, null);
    intent.setType("image/*");
    intent.putExtra("return-data", true);
    startActivityForResult(intent, 1);


    @Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    switch (requestCode) {

        case 1:
            if(requestCode == 1 && data != null && data.getData() != null){
                Uri _uri = data.getData();

                if (_uri != null) {
                    Cursor cursor = getContentResolver().query(_uri, new String[] { android.provider.MediaStore.Images.ImageColumns.DATA }, null, null, null);
                    cursor.moveToFirst();
                    final String imageFilePath = cursor.getString(0);
                    File photos= new File(imageFilePath);
                    imageView.setImageBitmap(bitmap);
                    cursor.close();
                }
            }
            super.onActivityResult(requestCode, resultCode, data);
        }
    }

why u call "super.onActivityResult(requestCode, resultCode, data);" twice ??!

Collectives™ on Stack Overflow

onActivityResult() not called when Activity started from Fragment

3 Answers 3

4 Comments

1 Comment

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

1 Comment

Linked

Related